Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling out-of-source build-and-test #1091

Merged
merged 5 commits into from
Sep 18, 2021
Merged

Enabling out-of-source build-and-test #1091

merged 5 commits into from
Sep 18, 2021

Conversation

baentsch
Copy link
Member

Provides fix to #1090 and enhances/completes #1080. CI failures still due to #1035.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the the list of algorithms available -- either adding, removing, or renaming? (If so, PRs in OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also be required by the time this is merged.)

@baentsch baentsch mentioned this pull request Sep 18, 2021
Closed
@dstebila dstebila merged commit 2757d16 into main Sep 18, 2021
@dstebila dstebila deleted the mb-furtherbuildpathfixes branch September 18, 2021 20:06
@yurivict
Copy link

yurivict commented Sep 18, 2021 •
edited
Loading

After the PR was merged there are still failures printing this:

E FileNotFoundError: [Errno 2] No such file or directory: 'build/include/oqs/oqsconfig.h'

rev. 2757d16

There is no build directory. My build directory is /usr/ports/security/liboqs/work/.build.

@baentsch baentsch mentioned this pull request Sep 19, 2021
Merged
2 tasks
@baentsch
Copy link
Member Author

My build directory is /usr/ports/security/liboqs/work/.build.

@yurivict, thanks for the example. #1093 corrected the remaining problem. Suggest to close #1090, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstebila dstebila dstebila approved these changes

@xvzcf xvzcf Awaiting requested review from xvzcf

@jschanck jschanck Awaiting requested review from jschanck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baentsch @yurivict @dstebila